Skip to content

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented May 9, 2025

Whenever XCtest is build and installed, do the same for swift-testing and swift-testing macros so projects can use whichever testing framework.

@bkhouri
Copy link
Contributor Author

bkhouri commented May 9, 2025

@bkhouri bkhouri requested review from DougGregor and etcwilde and removed request for DougGregor May 9, 2025 14:46
@MaxDesiatov MaxDesiatov requested a review from edymtt May 9, 2025 14:48
@MaxDesiatov MaxDesiatov added build-script Area → utils: The build script bootstrapping Area → utils → build-script: Bootstrapping schemes labels May 9, 2025
@bkhouri bkhouri force-pushed the t/main/update_presets branch from 8df6512 to 1d04798 Compare May 9, 2025 16:40
@bkhouri
Copy link
Contributor Author

bkhouri commented May 9, 2025

@bkhouri bkhouri requested a review from MaxDesiatov May 9, 2025 16:40
@bkhouri
Copy link
Contributor Author

bkhouri commented May 9, 2025

swiftlang/swift-package-manager#8495

@swift-ci smoke test macOS

@bkhouri
Copy link
Contributor Author

bkhouri commented May 9, 2025

Whenever XCtest is build and installed, do the same for swift-testing
and swift-testing macros.
@bkhouri bkhouri force-pushed the t/main/update_presets branch from 1d04798 to 2962ea2 Compare May 12, 2025 14:53
@bkhouri
Copy link
Contributor Author

bkhouri commented May 12, 2025

@bkhouri
Copy link
Contributor Author

bkhouri commented May 12, 2025

swiftlang/swift-package-manager#8495

@swift-ci smoke test linux

@bkhouri
Copy link
Contributor Author

bkhouri commented May 12, 2025

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could likely refactor some of this to a testing mixin

[preset: testing_runtimes_mixin]
xctest
swift-testing
swift-testing-macros

But then it's a matter of adding that preset mixin to each of the presets that use it under the mixin-preset flag.
Up to you.

Adding swift-testing to the second bootstrap stage is probably fine. Ideally we're building as few things in the bootstrap stages since they get thrown away, but I think that the final toolchain stage will use it when running tests on the SwiftPM packages.

@bkhouri bkhouri merged commit 1a6962f into swiftlang:main May 13, 2025
3 checks passed
bkhouri added a commit to swiftlang/swift-package-manager that referenced this pull request May 14, 2025
Convert `BasicsTests/Environment/*.swift`, `BasicsTests/Graph/*.swift`
and a couple other in BasicsTests to Swift Testing

Depends on: swiftlang/swift#81401
bkhouri added a commit to swiftlang/swift-package-manager that referenced this pull request May 14, 2025
Until #8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Related to: #8433
rdar://148248105
Depends on: swiftlang/swift#81401
hamishknight added a commit to hamishknight/swift that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrapping Area → utils → build-script: Bootstrapping schemes build-script Area → utils: The build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants