Skip to content

Windows Test failures #8433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
bkhouri opened this issue Mar 31, 2025 · 0 comments · May be fixed by #8616
Open
1 task done

Windows Test failures #8433

bkhouri opened this issue Mar 31, 2025 · 0 comments · May be fixed by #8616
Assignees
@bkhouri
Labels
bug test suite improvements to SwiftPM test suite windows

Comments

@bkhouri
Copy link
Contributor

bkhouri commented Mar 31, 2025

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

With #8210 merged, and #8176 (add windows self-hosted pipeline) a required PR build, we need to remove as many skipped tests on Windows as possible, and raise GitHub issues for actual Windows platform issues.

Acceptance Criteria:

  • remove as many skipped tests on Windows as possible
  • a GitHub issue exists to track a tests that is skipped on Windows

Expected behavior

No response

Actual behavior

No response

Steps to reproduce

No response

Swift Package Manager version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response
@bkhouri bkhouri added the bug label Mar 31, 2025
@bkhouri bkhouri self-assigned this Mar 31, 2025
@bkhouri bkhouri added windows test suite improvements to SwiftPM test suite labels Mar 31, 2025
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 1, 2025
@bkhouri
FIRST COMMIT: Enavbled all PathTests on Windows.. most still fail...
32713eb 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
a844b95 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
5fcc926 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
f77a6f1 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
@bkhouri bkhouri mentioned this issue Apr 3, 2025
Closed
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
68d31b1 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
304833a 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
0ad0aed 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
bcd4a5e 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
163886f 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Fixes: swiftlang#8433
Issue: rdar://148248105
Depends on: swiftlang#8448
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
c7673b6 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
23744ec 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Fixes: swiftlang#8433
Issue: rdar://148248105
Depends on: swiftlang#8448
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
c8a2703 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
Tests: Enable more Windows Windows tests
eba83b8 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 4, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
Tests: Enable more Windows Windows tests
bcda027 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 7, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Tests: Enable some WorkspaceTests on Windows
eab58ee 
Enable WorkspaceTests on Windows that, for some reason, previously
failed.

Relates: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 8, 2025
Merged
bkhouri added a commit that referenced this issue Apr 8, 2025
@bkhouri
Tests: Enabled SourceControlTests on Windows (#8453)
60976ee 
Some tests in Tests/SourceControlTests are passing on Windows since
upgrading the Git Version in the associated docker image, which was
completd in https://github.com/swiftlang/swift-docker/pulls/452

Enable the tests that are skipped.

Relates to: #8433 
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Tests: Enable tests on Windows
8048d4c 
- Enable a few AsyncProcessTests
- Enable the lone skipped test in EnvironmentTests
- Enable all SourceKitLSPAPITests on Windows
- Replace usages of `fixwin` with `AbsolutePath.pathString`

Related to: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 8, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Copy helper internally
99b2580 
Util $8223 is fixedd copy some helpers from IntergrationTests/Source/IntegrationTests
to Test/_InternalTestSupport so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Copy helper internally
0d1f881 
Until $8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests``
to `Test/_InternalTestSupport` so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 8, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
a07e0b1 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Tests: Reference issue in skipped SourceControlPackageContainerTests
bbc2ec2 
A few SourceControlPackageContainerTests fail for the same reason.  Keep skipping them but add a GitHub issue and the error that occurs to the skip reason

Relates to: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 30, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Tests: Enabled some BuildTests fon Windows
cc7f878 
- Enable the BuildPlanTests on Windows
- Split a PrepareForIndexTests tests into two withthe passing, and
  failing on Windows
- update/add a message on some skipped windows tests, with a reference
  to GitHub Issue

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Tests: Reference issue in skipped SourceControlPackageContainerTests
d74e53c 
A few SourceControlPackageContainerTests fail for the same reason.  Keep skipping them but add a GitHub issue and the error that occurs to the skip reason

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Tests: Reference issue in skipped SourceControlPackageContainerTests
c8478aa 
A few SourceControlPackageContainerTests fail for the same reason.  Keep skipping them but add a GitHub issue and the error that occurs to the skip reason

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Test: Guard a ManifestSourceGenerationTest and annotateskip message
c82728d 
Guard a test in ManifestSourceGenerationTest based on the compiler
version, and annotate skipped tests with a GitHub issue.

Relates to: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 30, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Tests: Reference issue in skipped SourceControlPackageContainerTests
4accf6c 
A few SourceControlPackageContainerTests fail for the same reason.  Keep skipping them but add a GitHub issue and the error that occurs to the skip reason

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 30, 2025
@bkhouri
Tests: Enabled some BuildTests fon Windows
0e5bbaa 
- Enable the BuildPlanTests on Windows
- Split a PrepareForIndexTests tests into two withthe passing, and
  failing on Windows
- update/add a message on some skipped windows tests, with a reference
  to GitHub Issue

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 1, 2025
@bkhouri
Test: Guard a ManifestSourceGenerationTest and annotateskip message
9392ce4 
Guard a test in ManifestSourceGenerationTest based on the compiler
version, and annotate skipped tests with a GitHub issue.

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 1, 2025
@bkhouri
Test: Guard a ManifestSourceGenerationTest and annotateskip message
21ce9e0 
Guard a test in ManifestSourceGenerationTest based on the compiler
version, and annotate skipped tests with a GitHub issue.

Also, enable the two Workspace Traits tests that were added after swiftlang#8569
was merged.

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 1, 2025
@bkhouri
Test: Guard a ManifestSourceGenerationTest and annotateskip message
4fe04db 
Guard a test in ManifestSourceGenerationTest based on the compiler
version, and annotate skipped tests with a GitHub issue.

Also, enable the two Workspace Traits tests that were added after swiftlang#8569
was merged.

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 1, 2025
@bkhouri
Tests: Reference issue in skipped SourceControlPackageContainerTests
6d07249 
A few SourceControlPackageContainerTests fail for the same reason.  Keep skipping them but add a GitHub issue and the error that occurs to the skip reason

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 1, 2025
@bkhouri
Tests: Convert Most Basics/FileSystem/* to Swift Testing
5724196 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 1, 2025
@bkhouri
Tests: Enable more Windows Windows tests
2c2a61e 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 2, 2025
@bkhouri
Test: Guard a ManifestSourceGenerationTest and annotateskip message
e6fc21b 
Guard a test in ManifestSourceGenerationTest based on the compiler
version, and annotate skipped tests with a GitHub issue.

Also, enable the two Workspace Traits tests that were added after swiftlang#8569
was merged.

Relates to: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit that referenced this issue May 2, 2025
@bkhouri
Tests: Enable some BuildTests/**/*.swift tests on Windows (#8512)
620cbb9 
- Enable the BuildPlanTests on Windows
- Split a PrepareForIndexTests tests into two withthe passing, and
  failing on Windows
- update/add a message on some skipped windows tests, with a reference
  to GitHub Issue

Related to: #8433
Depends on: #8569
rdar://148248105
bkhouri added a commit that referenced this issue May 2, 2025
@bkhouri
Tests: Reference issue in skipped SourceControlPackageContainerTests (#…
96d86b0 
…8579)

A few SourceControlPackageContainerTests fail for the same reason. Keep
skipping them but add a GitHub issue and the error that occurs to the
skip reason

Relates to: #8433
Issue: rdar://148248105
Depends on: #8569
bkhouri added a commit that referenced this issue May 2, 2025
@bkhouri
Tests: Enable BasicsTests/FileSystem/* Tests on Windows (Swift Testin…
879236b 
…g) (#8450)

Convert posted test from XCTest to Swift Testing, while updating to
ensuring we mark the tests that currently fail on windows.

Tests/BasicsTests/FileSystem/FileSystemTests.swift
Tests/BasicsTests/FileSystem/PathShimTests.swift
Tests/BasicsTests/FileSystem/PathTests.swift
Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
Tests/BasicsTests/FileSystem/VFSTests.swift

Depends on swiftlang/swift#81217
Partially Addresses: #8433
Issue: rdar://148248105
bkhouri added a commit that referenced this issue May 2, 2025
@bkhouri
Test: Guard a ManifestSourceGenerationTest and annotate skip message (#…
e8aff4b 
…8582)

Guard a test in ManifestSourceGenerationTest based on the compiler
version, and annotate skipped tests with a GitHub issue.

Also, enable the two Workspace Traits tests that were added after #8569
was merged.

Relates to: #8433
Issue: rdar://148248105
@bkhouri bkhouri changed the title Remove skipped tests on windows Windows Test failures May 5, 2025
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 5, 2025
@bkhouri
Test: Enable additional tests on Windows
6710de5 
Enabled additional tests on Windows  Since all tests on Windows are
either enabled, or are skipped with an associated GitHub issue, update
the XCTSkipOnWindows(...) helper API to require providing a reson as to
why the test is being skipped.

Fixes: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri linked a pull request May 5, 2025 that will close this issue
Open
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 12, 2025
@bkhouri
Test: Enable additional tests on Windows
f4638e3 
Enabled additional tests on Windows  Since all tests on Windows are
either enabled, or are skipped with an associated GitHub issue, update
the XCTSkipOnWindows(...) helper API to require providing a reson as to
why the test is being skipped.

Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue May 13, 2025
@bkhouri
Copy helpers internally (swiftlang#8467)
c36ee92 
Until swiftlang#8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit that referenced this issue May 14, 2025
@bkhouri
Copy helpers internally - take 3 (#8495)
9804c81 
Until #8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Related to: #8433
rdar://148248105
Depends on: swiftlang/swift#81401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkhouri bkhouri

Labels
bug test suite improvements to SwiftPM test suite windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test: Enable additional tests on Windows bkhouri/swift-package-manager
1 participant
@bkhouri