[SR-13571] build release and debug variants of swiftrt.obj, swiftCore #70230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I restored the code to its original state in 'test/stdlib/UnsafePointerDiagnostics.swift
Issue: [[SR-6360](https://bugs.swift.org/browse/SR-6360)] Tag: #48910 We could make things easier on people by adding an unavailable typealias with a renamed field. Resolve: #48910, fix: #69881
[stdlib]Catch the reasonable mistake 'UnsafeRawMutableBufferPointer'
- Modified: stdlib/public/core/UnsafeRawBufferPointer.swift
…state. - Modified: swift/stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
- Modified: swift/test/stdlib/UnsafePointerDiagnostics.swift
[stdlib]Catch the reasonable mistake 'UnsafeRawMutableBufferPointer'
Merge branch
- Modified: stdlib/public/core/UnsafeRawBufferPointer.swift
- Modified: swift/test/stdlib/UnsafePointerDiagnostics.swift
[stdlib]Catch the reasonable mistake 'UnsafeRawMutableBufferPointer'
- Modified: swift/test/stdlib/UnsafePointerDiagnostics.swift
- Modified: swift/test/stdlib/UnsafePointerDiagnostics.swift
… into develop-kobe
Previously the branches of a ternary would cut off the coverage after a throwing expression, since they have their own region, and we pop child regions when leaving. Update the logic to use the existing counter adjustment logic when we leave the scope, ensuring that we push a new counter to reflect the exit count of the scope.
Ensure that `try?` expressions appropriately scope the regions generated by child error-throwing expressions, such that the non-error branch does not extend beyond the region of the `try?`.
Previously we would ignore the effect that an if statement or ternary's condition exit counter might have on its branches, as we assumed a condition can't do any control flow. However, in the case where the condition throws an error, we need to account for the error branch.
…ture Prviously swift-ide-test enabled importing of ObjC forward declarations with the -enable-objc-forward-declarations option. The compiler enables the same behavior via -enable-upcoming-feature. Now that swift-ide-test also supports upcoming-features, make enabling the ImportObjcForwardDeclarations language feature have the expected effect in swift-ide-test. The old flag is also removed.
…e corresponding stored property.
…nitializers should be nonisolated if all initialized properties are Sendable with nonisolated default values.
Values produced by address-only `enum` instructions have non-none ownership. And because `enum` is representation-changing, they have `owned` ownership. This corresponds at the opaque values SIL stage to the fact that at the address-lowered SIL stage the storage location has non-trivial initialization which must be `destroy_addr`d, regardless of whether an empty case was stored to it.
… marked as invalid Capability couldn't be determined for expressions like that which means that inference should be delayed until root becomes available. Resolves: #69936
…tributes ClangImporter converts NS_SWIFT_SENDABLE into `SynthesizedProtocolAttr` which needs to be recognized by the request that collects all of the protocols that the given protocol inherits.
… for synthesized protocols ClangImporter adds `SynthesizedProtocolAttr` to model inheritance from `Sendable` on protocols imported from Objective-C.
…edNominalTypeDecls` Some places use `getDirectlyInheritedNominalTypeDecls` directly instead of fetching it through a request, so lift the check there instead (direct use of `getDirectlyInheritedNominalTypeDecls` could be refactored separately).
…ting from non-NSObject to warning
… of the embedded stdlib to cover common embedded targets
…rrency tests on Linux
…k correctly on Linux
./utils/cmpcodesize/cmpcodesize/main.py:20:71: E231 missing whitespace after ',' ./utils/round-trip-syntax-test:20:20: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` ./utils/round-trip-syntax-test:21:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` I can't find any uses of round-trip-syntax-test, so I don't know if this fix is correct.
This shouldn’t be needed anymore since we migrated code completion to be solver-based. rdar://91403086
…ssible The real-world use case here is the `Task` initializer in the added test case. In general, we should only prefer to insert an unapplied function reference if it has a better type relation than calling the function because, in most cases, you want to call functions and not get unapplied references to them. rdar://90456105
This test was already passing. Probably fixed by migrating to solver-based completions. rdar://88883761
…mpiler crash on unavailable accessors
Merge branch
merge in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify to build both debug and release variants, providing the runtime as
swiftCore.dllandswiftCored.dll, and enable building with both /MD and /MDd to activate debug builds.Issue: [SR-13571]