Skip to content

[stdlib]Catch the reasonable mistake 'UnsafeRawMutableBufferPointer' #69881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[stdlib]Catch the reasonable mistake 'UnsafeRawMutableBufferPointer' #69881

wants to merge 4 commits into from

Conversation

devKobe24
Copy link

@devKobe24 devKobe24 commented Nov 15, 2023

[stdlib]Catch the reasonable mistake 'UnsafeRawMutableBufferPointer'

Issue: [SR-6360]
Tag: #48910

We could make things easier on people by adding an unavailable typealias with a renamed field.

Resolve: #48910, fix: #69881

cc: @glessard

@devKobe24 devKobe24 requested a review from a team as a code owner November 15, 2023 11:09
@devKobe24
Copy link
Author

@swift-ci Please smoke test

@glessard
Copy link
Contributor

@devKobe24 thanks! This illustrates the behaviour you intend, but would not change the toolchain. The typealias would need to be in the standard library code, e.g. alongside the definition of UnsafeMutableRawBufferPointer.

I restored the code to its original state in 'test/stdlib/UnsafePointerDiagnostics.swift
Issue: [SR-6360]
Tag: #48910

We could make things easier on people by adding an unavailable typealias with a renamed field.

Resolve: #48910, fix: #69881

cc: @glessard
@devKobe24
Copy link
Author

@swift-ci Please smoke test

@devKobe24
Copy link
Author

@glessard

Hello,

Thank you so much for enlightening me on the crucial aspects.

It's my first contribution, and I'm quite nervous and excited, haha.

It's such a fun and thrilling adventure.

Sincerely from Korea, Kobe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SR-6360] Catch the reasonable mistake 'UnsafeRawMutableBufferPointer'
2 participants