[SR-14801] Completion in argument label position shows invalid non-argument-label completions (in result builder)

[ahoppen]

Previous ID	SR-14801
Radar	rdar://79555026
Original Reporter	@ahoppen
Type	Bug

Additional Detail from JIRA

Votes	0
Component/s	CodeCompletion
Labels	Bug
Assignee	None
Priority	Medium

md5: a775b8df2dedca081346ae7d15c9a1d0

Issue Description:

In the following test case when completing foo, bspectRatio gets added a second time after the (.

// RUN: %swift-ide-test -code-completion -source-filename %s -code-completion-token=COMPLETE

protocol View2 {}

extension Never: View2 {}

@resultBuilder struct ViewBuilder2 {
  static func buildBlock() -> Never { fatalError() }
  static func buildBlock<Content>(_ content: Content) -> Content where Content : View2 { fatalError() }
}

struct AsyncImage2<Content> : View2 where Content : View2 {
  init(@ViewBuilder2 content: @escaping (Image2) -> Content) { fatalError() }
}

struct Image2: View2 {}

extension View2 {
  func bspectRatio(foo: Int) -> Never { fatalError() }
}

struct ContentView: View2 {
  var body: some View2 {
    AsyncImage2() { image in
      image.bspectRatio(#^COMPLETE^#foo: 1)
    }
  }
}

[benlangmuir]

   Decl[InstanceMethod]/OutNominal:    bspectRatio({#foo: Int#})[#Never#]; name=bspectRatio(foo: Int)

This is not a completion of the argument label "foo". It is a completion of the method ContentView.bspectRatio(foo🙂, since the completion is inside ContentView.

There are a couple of problems here:

1. We are not showing the function call pattern completion "foo: <#Int#>)" at all
2. We are showing value completions in an argument label position when only argument labels are valid

Note that if there were an overload with an unlabeled first argument bspecRatio(_:...) then (2) would not apply and you should expect to see this method completion, but ideally with a lower priority than the argument label or call pattern completion (1).