[CodeComplete] Add test case for #57148, #57149 #70012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
force-pushed
the
ahoppen/test-case-for-57149
branch
from
735c691 to
8844fd8
Compare
ahoppen
changed the title
xedin
approved these changes
Nov 23, 2023
Contributor
xedin
left a comment
xedin
left a comment
There was a problem hiding this comment.
Nice! All these 2 are not needed though since the SwiftUI is not imported by the test :)
ahoppen
force-pushed
the
ahoppen/test-case-for-57149
branch
2 times, most recently
from
ce8b5d8 to
5f52cbb
Compare
The issue no longer occurs on `main`. Add a test case for it. Fixes swiftlang#57148 Fixes swiftlang#57149
ahoppen
force-pushed
the
ahoppen/test-case-for-57149
branch
from
5f52cbb to
423826f
Compare
Member
Author
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Nov 27, 2023
rintaro
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue no longer occurs on
main. Add a test case for it.Fixes #57148
Fixes #57149