[5.10][CMake] Replace early swift-syntax with FetchContent #68882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of letting CMake set RPATH of the test executables, use INSTALL_RPATH and BUILD_WITH_INSTALL_RPATH just like other executable and shared libraries. Previously when a swift module link with exported swift-syntax targets e.g. 'SwiftSyntax::SwiftParser', the libraries in earlyswiftsyntax were used instead of the copied libraries in the swift build directory. That wasn't ideal. (cherry picked from commit 891d7b7)
`BOOTSTRAPPING_MODE` was used for configuring `SWIFT_ENABLE_ARRAY_COW_CHECKS` before it's fully fixed. (cherry picked from commit 06bffb9)
[CMake] Replace early swift-syntax with FetchContent (cherry picked from commit 8dbde04)
This was referenced Sep 29, 2023
rdar://116239522 (cherry picked from commit d0dfd75)
`.dylib` was hardcoded. Accept other platforms' shared library filenames (cherry picked from commit e9a183c)
After FetchContent changes, macros in Windows were disabled. (cherry picked from commit 00f9935)
build-windows-toolchain.bat used to build and install 'swift-syntax' for the compiler. Now that swift-syntax is built as a part of 'swift' build. So no need to built it separately anymore. (cherry picked from commit fc03e2e)
rintaro
force-pushed
the
5.10-fetch-content
branch
from
76a9b53 to
ad889b3
Compare
bnbarham
approved these changes
Oct 5, 2023
|
@swift-ci Please test Windows |
|
swiftlang/swift-syntax#2252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick #68408 (and #68388, #68527, and #68867) into
release/5.10swift-syntaxhost libraries using FetchContent rather than early-swiftsyntax. This simplifies the overall toolchain build process and fix the issues we've seen caused by swift-syntax not being rebuilt. We should be able to use this to fix cross-compiling on Linux