Skip to content

[5.10][lldb][CMake] Update for swift-syntax FetchContent changes #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 29, 2023

cherry-pick #7424 into swift/release/5.10

  • Explanation: Build the swift-syntax host libraries using FetchContent rather than early-swiftsyntax. This simplifies the overall toolchain build process and fix the issues we've seen caused by swift-syntax not being rebuilt. We should be able to use this to fix cross-compiling on Linux
  • Scope: Build system
  • Risk: Mid, since we update the build mechanism. But removes some nasty hacks.
  • Testing: Passes the current test suite
  • Issues: rdar://115439072
  • Reviewer: Ben Barham (@bnbarham)

Rename SWIFT_SWIFT_PARSER with SWIFT_BUILD_SWIFT_SYNTAX

(cherry picked from commit 68b541d)
@rintaro
Copy link
Member Author

rintaro commented Sep 29, 2023

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Oct 2, 2023

@rintaro rintaro merged commit d496f4d into swiftlang:swift/release/5.10 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants