-
Notifications
You must be signed in to change notification settings - Fork 10.5k
build: fallback BOOTSTRAPPING_MODE
before the first use
#68527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fallback BOOTSTRAPPING_MODE
before the first use
#68527
Conversation
`BOOTSTRAPPING_MODE` was used for configuring `SWIFT_ENABLE_ARRAY_COW_CHECKS` before it's fully fixed.
preset=buildbot_incremental_linux_crosscompile_wasm |
preset=buildbot_incremental,tools=RA,stdlib=RA |
@swift-ci please smoke test |
Still the preset job is failing due to another issue, but #68538 will fix it. |
preset=buildbot_incremental_linux_crosscompile_wasm |
OK, but
Now that |
Yes, this is intended to be a quick fix to unblock other PRs. Will update the presets themselves separately 👍 |
BOOTSTRAPPING_MODE
was used before it's fully determined by a falling back logic (the fallback is introduced recently by 9017ef5).It results in validation test failure with
--bootstrapping=bootstrapping --enable-array-cow-checks
on Linux, which is used bybuildbot_incremental_linux_crosscompile_wasm
1.This PR just moves the code block for loading earlyswiftsyntax targets and falling back
BOOTSTRAPPING_MODE
before the first use of the variable.Footnotes
https://ci.swift.org/job/swift-PR-Linux-preset/69 ↩