Skip to content

build: fallback BOOTSTRAPPING_MODE before the first use #68527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Sep 14, 2023

BOOTSTRAPPING_MODE was used before it's fully determined by a falling back logic (the fallback is introduced recently by 9017ef5).

It results in validation test failure with --bootstrapping=bootstrapping --enable-array-cow-checks on Linux, which is used by buildbot_incremental_linux_crosscompile_wasm1.

This PR just moves the code block for loading earlyswiftsyntax targets and falling back BOOTSTRAPPING_MODE before the first use of the variable.

Footnotes

  1. https://ci.swift.org/job/swift-PR-Linux-preset/69

`BOOTSTRAPPING_MODE` was used for configuring
`SWIFT_ENABLE_ARRAY_COW_CHECKS` before it's fully fixed.
@kateinoigakukun
Copy link
Member Author

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

preset=buildbot_incremental,tools=RA,stdlib=RA
@swift-ci Please clean test with preset macOS

@kateinoigakukun
Copy link
Member Author

@swift-ci please smoke test

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Sep 15, 2023

Still the preset job is failing due to another issue, but #68538 will fix it.

@MaxDesiatov
Copy link
Contributor

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@rintaro
Copy link
Member

rintaro commented Sep 15, 2023

OK, but

It results in validation test failure with --bootstrapping=bootstrapping --enable-array-cow-checks on Linux, which is used by buildbot_incremental_linux_crosscompile_wasm

Now that --bootstrapping=bootstrapping is not supported in linux, so SWIFT_ENABLE_ARRAY_COW_CHECKS is now practically always FALSE? Is it OK?

@kateinoigakukun
Copy link
Member Author

Yes, this is intended to be a quick fix to unblock other PRs. Will update the presets themselves separately 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants