[5.7][SwiftCompiler/Regex] Use bridged DiagnosticEngine for error reporting #58390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes: * An issue where the diagnostic messages were leaked * Diagnose at correct position inside the regex literal To do this: * Introduce 'Parse' SwiftCompiler module that is a bridging layer between '_CompilerRegexParser' and C++ libParse * Move libswiftParseRegexLiteral and libswiftLexRegexLiteral to 'Parse' Also this change makes 'SwiftCompilerSources/Package.swift' be configured by CMake so it can actually be built with 'swift-build'. rdar://92187284 (cherry picked from commit d292a95)
…upport (cherry picked from commit 79bbbf1)
airspeedswift
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #42583 into
release/5.7SwiftCompilerModuleswritten in Swift. Previously, lexing/parsing error reporting was done by passing back a pointer to a C-string that is allocated in heap memory, and was never deallocated (leak). Also previously, since the error message didn't have the source location information, the diagnostic used to always point the start of the literal, that was confusing. In this change, utilize the bridgedDiagnosticEngineso we don't need to allocate C-string, and use the correct source location to diagnoseDiagnosticEngineto Swift. That said, it's just a pointer to C++DiagnosticEngine, and the actual diagnostic emitting logic is not new. So the risk it not too high.