[5.7]Preparation for location aware diagnostics in the compiler. #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving `libswiftLexRegexLiteral()` and `libswiftParseRegexLiteral()` to the compiler repository because these functions are basically just briding the compiler to the actual lexing/parsing function. * Make some Lexing error APIs public. * Make LocatedErrorProtocol public and expose the `location` property * Shift the location of `LocatedError` in `parseWithDelimiters` so the client can get the valid string indices of the passed-in literal string. (cherry picked from commit 89b80bf)
|
@swift-ci Please test |
rintaro
changed the title
|
Integration test (without swift changes) triggered swiftlang/swift#35202 (comment) passed: |
|
Integration test (with the corresponding swift changes) swiftlang/swift#58390 (comment) passed: |
stephentyrone
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-pick #321 into
swift/release/5.7)Corresponds to
swiftchange swiftlang/swift#58390Moving
libswiftLexRegexLiteral()andlibswiftParseRegexLiteral()tothe compiler repository because these functions are basically just
briding the compiler to the actual lexing/parsing function.
locationpropertyLocatedErrorinparseWithDelimitersso theclient can get the valid string indices of the passed-in literal string.