[SwiftCompiler/Regex] Use bridged DiagnosticEngine for error reporting #42583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
regex_diagnostics
branch
from
956d551 to
7ef26c7
Compare
rintaro
force-pushed
the
regex_diagnostics
branch
2 times, most recently
from
2498649 to
cc6632b
Compare
rintaro
commented
Apr 22, 2022
|
|
||
| #else // canImport(_CompilerRegexParser) | ||
|
|
||
| #warning("Regex parsing is disabled") |
rintaro
force-pushed
the
regex_diagnostics
branch
3 times, most recently
from
9c6d6c6 to
3710a3f
Compare
|
swiftlang/swift-experimental-string-processing#328 |
|
swiftlang/swift-experimental-string-processing#328 |
This fixes: * An issue where the diagnostic messages were leaked * Diagnose at correct position inside the regex literal To do this: * Introduce 'Parse' SwiftCompiler module that is a bridging layer between '_CompilerRegexParser' and C++ libParse * Move libswiftParseRegexLiteral and libswiftLexRegexLiteral to 'Parse' Also this change makes 'SwiftCompilerSources/Package.swift' be configured by CMake so it can actually be built with 'swift-build'. rdar://92187284
rintaro
force-pushed
the
regex_diagnostics
branch
from
3710a3f to
79bbbf1
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
Added a commit to resolve a Actual failurehttps://ci.swift.org/view/Pull%20Requests/job/swift-PR-Linux/1445/console |
hamishknight
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
For that:
ParseSwiftCompiler module that is a bridging layer between_CompilerRegexParserand C++ libParselibswiftParseRegexLiteralandlibswiftLexRegexLiteralfrom_CompilerRegexParsertoParseAlso this change makes
SwiftCompilerSources/Package.swiftbe configured by CMake so it can actually be built withswift-build.rdar://92187284