[5.3][CodeCompletion] Safer getEquivalentDeclContextFromSourceFile() #32820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be case where parentDC->getAsDecl() returns nullptr. I haven't been able to find a reproducer. rdar://problem/61765124 (cherry picked from commit 09f461b)
Member
Author
|
@swift-ci Please test |
rintaro
changed the title
akyrtzi
approved these changes
Jul 10, 2020
Member
Author
|
@swift-ci Please nominate |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32806 into
release/5.3nullptr, it falls back to normal completion, but it's better than crashing. For debug builds, added pretty stack trace and assertion to see more info when it happens again. I haven't been able to find a reproducer though.nullptrcheck