[CodeCompletion] Safer getEquivalentDeclContextFromSourceFile() #32806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be case where parentDC->getAsDecl() returns nullptr. I haven't been able to find a reproducer. rdar://problem/61765124
rintaro
force-pushed
the
ide-completion-rdar61765124
branch
from
e548fc1 to
09f461b
Compare
Member
Author
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be case where
parentDC->getAsDecl()returnsnullptr. I haven't been able to find a reproducer though.Safe nullptr check in release build. Added pretty stack trace and assertion to see more info when it happens again.
rdar://problem/61765124