Optimize read accessors to just borrow yielded storage references #19790
Conversation
|
@swift-ci Please test. |
|
Are yield lists comma separated? If so, you’ll probably need to add a production that includes an optional trailing comma, like the definition for TupleElement. Also, can you add a round-trip test to test/Syntax/round_trip_parse_gen.swift? |
|
Build failed |
rjmccall
force-pushed
the
read-optimizations
branch
from
96b59e9 to
6f1fd82
Compare
|
@swift-ci Please test. |
The parser doesn't actually accept an optional trailing comma currently.
Done. |
|
Build failed |
|
Build failed |
| if (!arg.isExpr()) return false; | ||
| auto argExpr = arg.peekExpr(); | ||
| auto lvExpr = findStorageReferenceExprForBorrow(argExpr); | ||
| if (!lvExpr) return false; |
There was a problem hiding this comment.
This whole check could be a method on ArgumentSource, then you don’t need to expose peekExpr().
There was a problem hiding this comment.
Good point; I'll do a follow-up if this test run goes through.
Per Slava's review on swiftlang#19790.
Per Slava's review on swiftlang#19790.
No description provided.