Skip to content

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 2, 2025

Add CMake scripting/etc. for the WinSDK cross-import overlay.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

Add CMake scripting/etc. for the WinSDK cross-import overlay.
@grynspan grynspan added this to the Swift 6.x (main) milestone Sep 2, 2025
@grynspan grynspan self-assigned this Sep 2, 2025
@grynspan grynspan added windows 🪟 Windows support build 🧱 Affects the project's build configuration or process attachments/activities 🖇️ Work related to attachments and/or activities cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) image-attachments 📸 Work related to image attachments labels Sep 2, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Sep 2, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Sep 2, 2025

@swift-ci test

@grynspan grynspan requested a review from compnerd September 2, 2025 20:47
@grynspan
Copy link
Contributor Author

grynspan commented Sep 3, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Sep 3, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Sep 3, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Sep 4, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Sep 5, 2025

@swift-ci test

@grynspan grynspan marked this pull request as ready for review September 8, 2025 15:09
@grynspan
Copy link
Contributor Author

grynspan commented Sep 8, 2025

Holding for a successful toolchain test run (unrelated failure occurred on the last run.)

grynspan added a commit to swiftlang/swift-installer-scripts that referenced this pull request Sep 8, 2025
Adds the files generated by swiftlang/swift-testing#1296. See also #403 for reference.
@grynspan
Copy link
Contributor Author

grynspan commented Sep 8, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Sep 9, 2025

Need to mark these symbols SPI as they're showing up in the emitted public module:

extension Testing.AttachableImageFormat {
  public var encoderCLSID: WinSDK.CLSID {
    get
  }
  public init(encoderCLSID: WinSDK.CLSID, encodingQuality: Swift.Float = 1.0)
  public init?(pathExtension: Swift.String, encodingQuality: Swift.Float = 1.0)
}
extension WinSDK.IWICBitmapSource {
  public static func _copyAttachableIWICBitmapSource(from imageAddress: Swift.UnsafeMutablePointer<WinSDK.IWICBitmapSource>, using factory: Swift.UnsafeMutablePointer<WinSDK.IWICImagingFactory>) throws -> Swift.UnsafeMutablePointer<WinSDK.IWICBitmapSource>
}

@grynspan
Copy link
Contributor Author

grynspan commented Sep 9, 2025

@swift-ci test

@grynspan grynspan merged commit 3366f65 into main Sep 9, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/winsdk-overlay-cmake branch September 9, 2025 16:08
grynspan added a commit to swiftlang/swift-installer-scripts that referenced this pull request Sep 9, 2025
* WiX: Add the Testing/WinSDK cross-import overlay

Adds the files generated by swiftlang/swift-testing#1296. See also #403 for reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attachments/activities 🖇️ Work related to attachments and/or activities build 🧱 Affects the project's build configuration or process cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) image-attachments 📸 Work related to image attachments windows 🪟 Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants