-
Notifications
You must be signed in to change notification settings - Fork 43
WiX: package up the Testing cross-module overlay #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package the cross module overlay for Testing into the distribution on Windows for Windows and Android SDKs.
Tested with a prebuild from https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5830/artifact/build/artifacts/installer.exe with help from @grynspan Ran the following snippet: import Testing
import Foundation
@Test func test() {
let data = Data()
Attachment.record(data)
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this looks like what you'd need to get the cross-import overlay working. LGTM, thanks!
@compnerd Does this need to be cherry-picked? |
Approved with a note, I don't actually see an accepted proposal for cross-import libraries. The Swift-Testing proposal only references the pitch thread. I'm not sure what the rules are here, but I'm pretty sure that accepted features should only be built on accepted features. |
@grynspan yes, we should cherry-pick this. |
@etcwilde Cross-import overlays haven't been approved as a supported feature; our use here is necessary because Swift Testing is part of the toolchain and there is a circular dependency between Foundation and Swift Testing if Swift Testing puts these interfaces directly in the main (I'm on leave and won't respond further right now—please ping Becca, @stmontgomery, or @briancroom if you have further questions.) |
This adds the swift-testing cross-module overlay to the distribution on Windows.