Add support for @lifetime(borrow ...) #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please test with following pull request: @swift-ci Please test |
ahoppen
reviewed
Nov 7, 2024
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thanks, LGTM, just two minor comments.
| func derive6(ne: borrowing NE, neOut: inout NE) -> NE { neOut = ne } | ||
| """ | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
Could you also add a test case for borrow blah in a normal expression position and one that ensure we parse borrow(blah), borrow (blah) as function calls?
Contributor
Author
|
Please test with following pull request: @swift-ci Please test |
ahoppen
approved these changes
Nov 7, 2024
meg-gupta
force-pushed
the
lifetimeborrow
branch
from
05d5d5f to
bbf0023
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.