[Macros] Copy MacroSystem and related code to SwiftSyntaxMacroExpansion #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 27, 2023
DougGregor
approved these changes
Jun 27, 2023
rintaro
force-pushed
the
macros-macrossystem-expansion
branch
from
2e558fc to
58b8e84
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
And deperecate the original in SwiftSyntaxMacros module. 'MacroSystem' (i.e. 'SyntaxProtocol.expand(macros:in:)') is a syntactic macro expansion utility for testing macros (i.e. assertMacroExpansion()) It should be moved to `SwiftSyntaxMacroExpansion` module because it's a _expansion_ utility, and should share the same code with other expansion functions including the actual compiler expansion.
rintaro
force-pushed
the
macros-macrossystem-expansion
branch
from
58b8e84 to
fabcf50
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And deprecate the original in
SwiftSyntaxMacrosmodule.MacroSystem(i.e.SyntaxProtocol.expand(macros:in:)) is a syntactic macro expansion utility for testing macros (i.e.assertMacroExpansion()) It should be moved toSwiftSyntaxMacroExpansionmodule because it's a expansion utility, and should share the same code with other expansion functions including the actual compiler expansion.This is basically a pure copy, without any functional changes. Integrating unified logic will be separate PRs.