Stop using _openExistential #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Jul 3, 2023
| private func expandAccessorMacro(attribute: AttributeSyntax, attachedTo: DeclSyntax) -> AccessorListSyntax { | ||
| fatalError("unimplemented") | ||
| } | ||
|
|
There was a problem hiding this comment.
This part was added by accident when I copied MacroSystem in #1858
rintaro
commented
Jul 3, 2023
| @@ -493,27 +470,6 @@ extension MacroApplication { | |||
| ) | |||
| } | |||
|
|
|||
| private func expandMemberAttribute( | |||
There was a problem hiding this comment.
This function was not used.
|
@swift-ci Please test |
bnbarham
approved these changes
Jul 3, 2023
SE-0352 Implicitly Opened Existential https://github.com/apple/swift-evolution/blob/main/proposals/0352-implicit-open-existentials.md is supported widely enough.
rintaro
force-pushed
the
macros-openexistential
branch
from
2b845dc to
9a4a78a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0352 Implicitly Opened Existential is supported widely enough.