Skip to content

Commit c8478aa

Browse files
committed
Tests: Reference issue in skipped SourceControlPackageContainerTests
A few SourceControlPackageContainerTests fail for the same reason. Keep skipping them but add a GitHub issue and the error that occurs to the skip reason Relates to: swiftlang#8433 Issue: rdar://148248105
1 parent b092abe commit c8478aa

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

Tests/WorkspaceTests/SourceControlPackageContainerTests.swift

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ private let v1Range: VersionSetSpecifier = .range("1.0.0" ..< "2.0.0")
125125

126126
final class SourceControlPackageContainerTests: XCTestCase {
127127
func testVprefixVersions() async throws {
128-
try XCTSkipOnWindows()
128+
try XCTSkipOnWindows(because: """
129+
https://github.com/swiftlang/swift-package-manager/issues/8578
130+
""")
129131

130132
let fs = InMemoryFileSystem()
131133
try fs.createMockToolchain()
@@ -172,7 +174,9 @@ final class SourceControlPackageContainerTests: XCTestCase {
172174
}
173175

174176
func testVersions() async throws {
175-
try XCTSkipOnWindows()
177+
try XCTSkipOnWindows(because: """
178+
https://github.com/swiftlang/swift-package-manager/issues/8578
179+
""")
176180

177181
let fs = InMemoryFileSystem()
178182
try fs.createMockToolchain()
@@ -270,7 +274,9 @@ final class SourceControlPackageContainerTests: XCTestCase {
270274
}
271275

272276
func testPreReleaseVersions() async throws {
273-
try XCTSkipOnWindows()
277+
try XCTSkipOnWindows(because: """
278+
https://github.com/swiftlang/swift-package-manager/issues/8578
279+
""")
274280

275281
let fs = InMemoryFileSystem()
276282
try fs.createMockToolchain()
@@ -319,7 +325,9 @@ final class SourceControlPackageContainerTests: XCTestCase {
319325
}
320326

321327
func testSimultaneousVersions() async throws {
322-
try XCTSkipOnWindows()
328+
try XCTSkipOnWindows(because: """
329+
https://github.com/swiftlang/swift-package-manager/issues/8578
330+
""")
323331

324332
let fs = InMemoryFileSystem()
325333
try fs.createMockToolchain()
@@ -374,7 +382,7 @@ final class SourceControlPackageContainerTests: XCTestCase {
374382
func testDependencyConstraints() throws {
375383
#if ENABLE_TARGET_BASED_DEPENDENCY_RESOLUTION
376384
#else
377-
try XCTSkipIf(true)
385+
try XCTSkipIf(true, "Target based dependency resolution is disabled")
378386
#endif
379387

380388
let dependencies: [PackageDependency] = [

0 commit comments

Comments
 (0)