Handle new delete_pending error code when stating index unit files
#8838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple clang processes race to write out the same index file via renaming a newly generated index file ontop of the stale one. On Windows, there is a small window where the destination path is marked for deletion, and querying the file at this time would return a misleading `permission_denied` error (which is the Win32 error mapping from the underlying NTSTATUS code `STATUS_DELETE_PENDING`). An upstream change has modified the `fs::status` function on Windows to detect this case and return a more accurate `delete_pending` error code, which can be handled here as if the file is already deleted (i.e. `no_such_file_or_directory`)
bnbarham
approved these changes
Jun 4, 2024
|
Thanks 🙇♂️ |
compnerd
approved these changes
Jun 5, 2024
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Jan 13, 2025
Apply the same fix as swiftlang/llvm-project#8838 to the index writer in swift/lib/Index/IndexRecord.cpp noting it is meant to be merged with the IndexUnitWriter in LLVM. This should fix intermittent permission denied errors during builds that swiftlang/llvm-project#8838 fixes (but missed this one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple clang processes race to write out the same index file via renaming a newly generated index file ontop of the stale one. On Windows, there is a small window where the destination path is marked for deletion, and querying the file at this time would return a misleading
permission_deniederror (which is the Win32 error mapping from the underlying NTSTATUS codeSTATUS_DELETE_PENDING). An upstream change has modified thefs::statusfunction on Windows to detect this case and return a more accuratedelete_pendingerror code, which can be handled here as if the file is already deleted (i.e.no_such_file_or_directory).The
delete_pendingerror code was introduced here: llvm#90655cc @compnerd