Handle delete_pending error code #78620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the same fix as swiftlang/llvm-project#8838 to the index writer in swift/lib/Index/IndexRecord.cpp noting it is meant to be merged with the IndexUnitWriter in LLVM. This should fix intermittent permission denied errors during builds that swiftlang/llvm-project#8838 fixes (but missed this one).
hjyamauchi
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
|
CC @z2oh |
bnbarham
approved these changes
Jan 13, 2025
compnerd
approved these changes
Jan 13, 2025
|
@hjyamauchi probably want to cherry-pick this to 6.1 as well? |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same fix as
swiftlang/llvm-project#8838 to the index writer in swift/lib/Index/IndexRecord.cpp noting it is meant to be merged with the IndexUnitWriter in LLVM.
This should fix intermittent permission denied errors during builds that swiftlang/llvm-project#8838 fixes (but missed this one).