redirects ignore EventLoop preference - issue#88 #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldewailly
commented
Aug 21, 2019
| @@ -487,8 +487,9 @@ class HTTPClientTests: XCTestCase { | |||
|
|
|||
| func testEventLoopArgument() throws { | |||
| let httpBin = HttpBin() | |||
| let eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: 1) | |||
| let httpClient = HTTPClient(eventLoopGroupProvider: .shared(eventLoopGroup)) | |||
| let eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: 5) | |||
There was a problem hiding this comment.
We need more than 1 thread or this test is meaningless
artemredkin
approved these changes
Aug 21, 2019
ldewailly
force-pushed
the
issue#88_el_pref_on_redirect
branch
from
d04a722 to
9e82eeb
Compare
|
Thank you @ldewailly ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #88 for details