Skip to content

redirects ignore EventLoop preference #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weissi opened this issue Aug 20, 2019 · 2 comments
Closed

redirects ignore EventLoop preference #88

weissi opened this issue Aug 20, 2019 · 2 comments
Labels
kind/bug Feature doesn't work as expected.
Milestone
1.0.0

Comments

@weissi
Copy link
Contributor

weissi commented Aug 20, 2019 •
edited
Loading

@t089

Note, that redirects will ignore the preference parameter, won't they?

async-http-client/Sources/AsyncHTTPClient/HTTPClient.swift

Line 218 in 8fa354d

self.execute(request: newRequest, delegate: delegate, deadline: deadline)

Indeed looks like this part is missing?

Originally posted by @t089 in #79 (comment)
@weissi
Copy link
Contributor Author

weissi commented Aug 20, 2019

sorry, I merged the PR because it had 3 accepts. But that's something we need to fix.

@weissi weissi mentioned this issue Aug 20, 2019
Merged
@weissi weissi added the kind/bug Feature doesn't work as expected. label Aug 20, 2019
@weissi weissi added this to the 1.0.0 milestone Aug 20, 2019
@ldewailly ldewailly mentioned this issue Aug 21, 2019
Merged
@artemredkin
Copy link
Collaborator

This was solved by #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@artemredkin @weissi