Skip to content

Remove the last remaining NIOAtomic #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Remove the last remaining NIOAtomic #607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ea91fa
Remove the last remaining NIOAtomic
Lukasa Aug 3, 2022
63ea00b
Import order
Lukasa Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/AsyncHTTPClient/HTTPClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//
//===----------------------------------------------------------------------===//

import Atomics
import Foundation
import Logging
import NIOConcurrencyHelpers
Expand All @@ -36,7 +37,7 @@ extension Logger {
}
}

let globalRequestID = NIOAtomic<Int>.makeAtomic(value: 0)
let globalRequestID = ManagedAtomic(0)

/// HTTPClient class provides API for request execution.
///
Expand Down Expand Up @@ -541,7 +542,7 @@ public class HTTPClient {
logger originalLogger: Logger?,
redirectState: RedirectState?
) -> Task<Delegate.Response> {
let logger = (originalLogger ?? HTTPClient.loggingDisabled).attachingRequestInformation(request, requestID: globalRequestID.add(1))
let logger = (originalLogger ?? HTTPClient.loggingDisabled).attachingRequestInformation(request, requestID: globalRequestID.wrappingIncrementThenLoad(ordering: .relaxed))
let taskEL: EventLoop
switch eventLoopPreference.preference {
case .indifferent:
Expand Down