Remove the last remaining NIOAtomic #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation Warnings aren't great, and NIOAtomic is deprecated. Modifications Replace the last use of NIOAtomic with ManagedAtomic. Result Fewer warnings Fixes swift-server#606
dnadoba
approved these changes
Aug 3, 2022
|
One minor thing, maybe the version constraints in Package.swift should require versions that don't use NIOAtomics |
|
Do you mean versions of swift-nio? I don't think that's necessary: there are no relevant correctness issues with old copies of NIO, and we don't require the new ones, so there's no particular issue with letting users resolve older versions if that's necessary to get a buildable tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Warnings aren't great, and NIOAtomic is deprecated.
Modifications
Replace the last use of NIOAtomic with ManagedAtomic.
Result
Fewer warnings
Fixes #606