use .classList.toggle instead of add / remove #3189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if toggle is undefined, `.toggle` will act as a flip flop (wich the name "toggle" should imply) if toggle is true, it will add the class unless it is already contained if toggle is false, it will remove the class unless it is already removed alternatively i'd probably suggest renaming it from toggle_class to something else. a toggle is a state aware flip flop by default. any objections?
|
@Conduitry nice insight. thanks for clearification. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if toggle is undefined,
.togglewill act as a flip flop (wich the name "toggle" should imply)if toggle is true, it will add the class unless it is already contained
if toggle is false, it will remove the class unless it is already removed
alternatively i'd probably suggest renaming it from toggle_class to something else. a toggle is a state aware flip flop by default.
any objections?