fix(perf): use if in toggle_class instead of dynamic property access shenanigans
#8631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s shenanigans This is about 10% faster in Chrome, likely due to JITs being able to do a better thing Closes sveltejs#8629 (is a rework of)
|
@akx is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
|
Closing in favor of the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8629 (is a rework of it).
Following the discussion in #8629 (and an early predecessor #3189), instead of using
.toggle(... force), a plain oldifproves to be about 10% faster in Chrome, likely due to JITs being able to do a better thing.Micro-benchmark: https://gist.github.com/akx/76818fb782a232b5e08eae785cb3ee97