Skip to content

fix: consider img with loading attribute not static #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-chicken-wonder.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: consider img with loading attribute not static
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ function is_static_element(node) {
return false;
}

// We need to apply src and loading after appending the img to the DOM for lazy loading to work
if (node.name === 'img' && attribute.name === 'loading') {
return false;
}

if (node.name.includes('-')) {
return false; // we're setting all attributes on custom elements through properties
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { test } from '../../test';

export default test({
html: `<h1></h1><img src="..." loading="lazy" />`
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<h1></h1>
<img src="..." loading="lazy">
Loading