Skip to content

fix: consider img with loading attribute not static #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

paoloricciuti
Copy link
Member

Closes #14235

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link
Contributor

github-actions bot commented Nov 9, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14237

Copy link

changeset-bot bot commented Nov 10, 2024

🦋 Changeset detected

Latest commit: 2b439bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Ben McCann <[email protected]>
@paoloricciuti paoloricciuti merged commit d207666 into main Nov 10, 2024
11 checks passed
@paoloricciuti paoloricciuti deleted the loading-lazy-no-static branch November 10, 2024 16:48
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img with loading attribute will lead to "read properties of undefined (reading 'loading')"
2 participants