Skip to content

Conversation

@pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 10, 2025

Description

For better code organization and clearer reporting of code paths in logs, moving the model abstract base class definition from types into the models subpackage. Additionally, I am removing the base openai model class in favor of deriving from the main openai model class when needed.

Related Issues

No formal issue opened.

Documentation PR

strands-agents/docs#128

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare
  • Also ran the model integ tests.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy marked this pull request as ready for review July 10, 2025 19:54
@pgrayy pgrayy requested a review from awsarron July 10, 2025 21:58
@pgrayy pgrayy merged commit 89d261e into strands-agents:main Jul 11, 2025
12 checks passed
@pgrayy pgrayy deleted the model-types branch July 14, 2025 13:18
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants