Skip to content

Conversation

@pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 10, 2025

Description

We have moved the abstract model class from types into the models subpackage. For more details, please see strands-agents/sdk-python#409.

Note, the workflow is failing with the error:

ERROR   -  mkdocstrings: strands.models.model could not be found
ERROR   -  Error reading page 'api-reference/models.md':
ERROR   -  Could not collect 'strands.models.model'

This will be resolved once the above PR is released into PyPI.

Type of Change

  • New content addition
  • Content update/revision
  • Structure/organization improvement
  • Typo/formatting fix
  • Bug fix
  • Other (please describe):

Checklist

  • I have read the CONTRIBUTING document
  • My changes follow the project's documentation style
  • I have tested the documentation locally using mkdocs serve
  • Links in the documentation are valid and working
  • Images/diagrams are properly sized and formatted
  • All new and existing tests pass

Additional Notes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@Unshure Unshure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the approval workflow is failing, will this fix it? Does your mkdocs serve pass locally?

@Unshure
Copy link
Member

Unshure commented Jul 13, 2025

I see the approval workflow is failing, will this fix it? Does your mkdocs serve pass locally?

Pulled and built locally, it passed.

@Unshure Unshure merged commit 4c44049 into strands-agents:main Jul 13, 2025
1 of 2 checks passed
@pgrayy pgrayy deleted the model-type branch December 4, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants