This repository was archived by the owner on Jun 5, 2025. It is now read-only.
fix: Logging module always producing JSON #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now even if we specify that we want TEXT logging output Codegate will use JSON. This fixes it. It also introduces `structlog` as a convenient already built formatter instead of making our own formatters hand-made
aponcedeleonch
force-pushed
the
fix-logging
branch
from
91eee8a to
48bf9a3
Compare
Member
Author
|
Logging examples after this change TEXT
JSON
|
lukehinds
approved these changes
Nov 29, 2024
lukehinds
left a comment
lukehinds
left a comment
There was a problem hiding this comment.
Nice work! and thank you for updating docs too!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now even if we specify that we want TEXT logging output Codegate will use JSON. This fixes it. It also introduces
structlogas a convenient already built formatter instead of making our own formatters hand-madeCloses: #111