feat: handle pagination in policy collection mapping query #81
Conversation
### what use pagination with the cursor for query to get policy collection mappings ### why handle the case where the desired entry is not within first page of results ### testing acceptance tests and tested in sandbox ### docs n/a
| if !query.PolicyCollection.PolicyMappings.PageInfo.HasNextPage { | ||
| return nil, NotFound{"Policy collection mapping not found"} | ||
| } | ||
| cursor = query.PolicyCollection.PolicyMappings.PageInfo.EndCursor |
There was a problem hiding this comment.
@albertodonato I haven't checked but am trusting you that this DTRT when there's < 100 results in total 😅
There was a problem hiding this comment.
yeah when there's < 100 results, HasNextPage is false, so it would exit earlier.
| } `graphql:"policyCollection(uuid: $uuid)"` | ||
| } | ||
| cursor := "" | ||
| for { |
There was a problem hiding this comment.
@albertodonato The unbounded forever loop which only ends on the API tell us it's done or giving us an error makes me twitch a little. I don't know that there's a better way and it's definitely not blocking, just idle musing on my part.
There was a problem hiding this comment.
The way the connection protocol works is really meant to be unrolled page by page. It does have a total attribute that we could use to know ahead how many entries are there, but it could in theory become inconsistent if entries are added/removed between calls, so we'd have to have additional logic around it.
| } | ||
| cursor := "" | ||
| for { | ||
| var query struct { |
There was a problem hiding this comment.
@albertodonato I was surprised to see this struct inline inside the for loop; I don't know if that's just normal/idiomatic for go, but it makes for quite deep indentation/nesting. Again, just unblocking commentary.
There was a problem hiding this comment.
yeah we can actually move the query and variables definition outside of the loop, since they don't really depend on the entry. Updated
albertodonato
force-pushed
the
ack/policy-collection-mapping-use-cursor
branch
from
83d409a to
765a789
Compare
what
use pagination with the cursor for query to get policy collection mappings
why
handle the case where the desired entry is not within first page of results
testing
acceptance tests and tested in sandbox
docs
n/a