review comments

Author: albertodonato

internal/api/policy_collection_mapping.go

@@ -54,22 +54,21 @@ type policyCollectionMappingAPI struct {
 // Read returns data for a policy collection mapping.
 func (a policyCollectionMappingAPI) Read(ctx context.Context, collectionUUID string, policyUUID string) (*PolicyCollectionMapping, error) {
 	cursor := ""
+	var query struct {
+		PolicyCollection struct {
+			PolicyMappings struct {
+				Edges []struct {
+					Node PolicyCollectionMapping
+				}
+				PageInfo struct {
+					HasNextPage bool
+					EndCursor   string
+				}
+				Problems []Problem
+			} `graphql:"policyMappings(first: 100, after: $cursor)"`
+		} `graphql:"policyCollection(uuid: $uuid)"`
+	}
 	for {
-		var query struct {
-			PolicyCollection struct {
-				PolicyMappings struct {
-					Edges []struct {
-						Node PolicyCollectionMapping
-					}
-					PageInfo struct {
-						HasNextPage bool
-						EndCursor   string
-					}
-					Problems []Problem
-				} `graphql:"policyMappings(first: 100, after: $cursor)"`
-			} `graphql:"policyCollection(uuid: $uuid)"`
-		}
-
 		variables := map[string]any{
 			"uuid":   graphql.String(collectionUUID),
 			"cursor": graphql.String(cursor),

internal/api/repository.go

@@ -123,22 +123,22 @@ func (a repositoryAPI) Read(ctx context.Context, uuid string) (*Repository, erro
 
 func (a repositoryAPI) FindByURL(ctx context.Context, url string) (string, error) {
 	cursor := ""
-	for {
-		var q struct {
-			Conn struct {
-				Edges []struct {
-					Node struct {
-						URL  string
-						UUID string
-					}
-				}
-				PageInfo struct {
-					HasNextPage bool
-					EndCursor   string
+	var q struct {
+		Conn struct {
+			Edges []struct {
+				Node struct {
+					URL  string
+					UUID string
 				}
-				Problems []Problem
-			} `graphql:"repositoryConfigs(first: 100, after: $cursor)"`
-		}
+			}
+			PageInfo struct {
+				HasNextPage bool
+				EndCursor   string
+			}
+			Problems []Problem
+		} `graphql:"repositoryConfigs(first: 100, after: $cursor)"`
+	}
+	for {
 		variables := map[string]any{"cursor": graphql.String(cursor)}
 		if err := a.c.Query(ctx, &q, variables); err != nil {
 			return "", NewAPIError(err)