Skip to content

tests.utils.test_to_from_dict conflicts with other test runners #387

@schwehr

Description

@schwehr

I'm using a different test running. It sees this in tests/utils/__init__.py as a test:

def test_to_from_dict(
    test_class: unittest.TestCase,
    stac_object_class: Type[pystac.STACObject],
    d: Dict[str, Any],
) -> None:

Could we rename it to something without test_ as the start of the function? e.g. even def to_from_dict or assert_to_from_dict?

tests/extensions/test_eo.py::EOTest::test_summaries SKIPPED                                                                                                                  [ 50%]
tests/extensions/test_eo.py::EOTest::test_to_from_dict SKIPPED                                                                                                               [ 54%]
tests/extensions/test_eo.py::EOTest::test_validate_eo PASSED                                                                                                                 [ 59%]
tests/extensions/test_eo.py::test_to_from_dict_orig ERROR                                                                                                                    [ 63%]
tests/extensions/test_eo.py::TestCases::test_case_1 PASSED                                                                                                                   [ 68%]
tests/extensions/test_eo.py::TestCases::test_case_2 PASSED                                                                                                                   [ 72%]
tests/extensions/test_eo.py::TestCases::test_case_3 PASSED                                                                                                                   [ 77%]
tests/extensions/test_eo.py::TestCases::test_case_4 PASSED                                                                                                                   [ 81%]
tests/extensions/test_eo.py::TestCases::test_case_5 PASSED                                                                                                                   [ 86%]
tests/extensions/test_eo.py::TestCases::test_case_6 PASSED                                                                                                                   [ 90%]
tests/extensions/test_eo.py::TestCases::test_case_7 PASSED                                                                                                                   [ 95%]
tests/extensions/test_eo.py::TestCases::test_case_8 PASSED                                                                                                                   [100%]

====================================================================================== ERRORS ======================================================================================
_____________________________________________________________________ ERROR at setup of test_to_from_dict_orig _____________________________________________________________________
file pystac/tests/utils/__init__.py, line 22
  def test_to_from_dict(
E       fixture 'test_class' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

pystac/tests/utils/__init__.py:22
================================================================== 19 passed, 2 skipped, 1 error in 1.07 seconds ===================================================================

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions