Skip to content

Conversation

@namannimmo10
Copy link
Contributor

@namannimmo10 namannimmo10 commented Jun 2, 2021

Related Issue(s):
Fixes #387

Description:
Modifies def test_to_from_dict in tests/utils/__init__.py to def assert_to_from_dict to avoid conflict with other test runners

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some places where the function name still needs to be updated.

From the CI logs:

tests/test_item.py:14: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_view.py:6: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_timestamps.py:8: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_raster.py:15: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_projection.py:9: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_pointcloud.py:16: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_label.py:19: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_file.py:5: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]
tests/extensions/test_eo.py:9: error: Module 'tests.utils' has no attribute 'test_to_from_dict'; maybe "assert_to_from_dict"?  [attr-defined]

@duckontheweb duckontheweb merged commit 5f0e052 into stac-utils:main Jun 2, 2021
@namannimmo10 namannimmo10 deleted the patch-1 branch June 2, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.utils.test_to_from_dict conflicts with other test runners

2 participants