Skip to content

Add ServerAuthenticationConverter interface #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add ServerAuthenticationConverter interface #5689

wants to merge 1 commit into from

Conversation

edeandrea
Copy link
Contributor

@edeandrea edeandrea commented Aug 17, 2018

Redo of gh-5340

  • Adding a ServerAuthenticationConverter interface
  • Retro-fitting ServerOAuth2LoginAuthenticationTokenConverter,
    ServerBearerTokenAuthentivationConverter, ServerFormLoginAuthenticationConverter,
    and ServerHttpBasicAuthenticationConverter to implement ServerAuthenticationConverter
  • Deprecate existing AuthenticationWebFilter.setAuthenticationConverter
    and add overloaded one which takes ServerAuthenticationConverter

Fixes gh-5338

- Adding an ServerAuthenticationConverter interface
- Retro-fitting ServerOAuth2LoginAuthenticationTokenConverter,
 ServerBearerTokenAuthentivationConverter, ServerFormLoginAuthenticationConverter,
 and ServerHttpBasicAuthenticationConverter to implement ServerAuthenticationConverter
- Deprecate existing AuthenticationWebFilter.setAuthenticationConverter
and add overloaded one which takes ServerAuthenticationConverter

Fixes gh-5338
@rwinch rwinch self-assigned this Aug 19, 2018
@rwinch rwinch added this to the 5.1.0.RC1 milestone Aug 19, 2018
@rwinch
Copy link
Member

rwinch commented Aug 19, 2018

Thanks for the PR! This is now merged in via b6afe66 and polished via e3eaa99

@rwinch rwinch closed this Aug 19, 2018
@edeandrea edeandrea deleted the gh-5338-2 branch September 21, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants