Skip to content

Add AuthenticationConverter interface #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edeandrea opened this issue May 11, 2018 · 1 comment
Closed

Add AuthenticationConverter interface #5338

edeandrea opened this issue May 11, 2018 · 1 comment
Labels
in: docs An issue in Documentation or samples in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Comments

@edeandrea
Copy link
Contributor

Based on the discussion in #5328 add an AuthenticationConverter interface that is used within the AuthenticationWebFilter. This interface should look like

@FunctionalInterface
public interface AuthenticationConverter extends Function<ServerWebExchange, Mono<Authentication>> {

}

Then retrofit ServerFormLoginAuthenticationConverter, ServerHttpBasicAuthenticationConverter, and ServerOAuth2LoginAuthenticationTokenConverter to implement AuthenticationConverter.

Deprecate the existing

public void setAuthenticationConverter(Function<ServerWebExchange, Mono<Authentication>> authenticationConverter)

and add a new method

public void setAuthenticationConverter(AuthenticationConverter authenticationConverter)
@edeandrea edeandrea mentioned this issue May 11, 2018
Closed
@rwinch rwinch added this to the 5.1.0.M1 milestone May 11, 2018
@rwinch rwinch added in: docs An issue in Documentation or samples in: web An issue in web modules (web, webmvc) Reactive type: enhancement A general enhancement labels May 11, 2018
@edeandrea edeandrea mentioned this issue May 11, 2018
Closed
@edeandrea
Copy link
Contributor Author

edeandrea commented May 11, 2018 •
edited
Loading

I added #5689 for this

@rwinch rwinch modified the milestones: 5.1.0.M1, 5.1.0.M2 May 15, 2018
@rwinch rwinch modified the milestones: 5.1.0.M2, 5.1.0.RC1 Jul 26, 2018
@edeandrea edeandrea mentioned this issue Aug 17, 2018
Closed
@rwinch rwinch closed this as completed in b6afe66 Aug 19, 2018
rwinch added a commit that referenced this issue Aug 19, 2018
@rwinch
Polish ServerAuthenticationConverter
e3eaa99 
Update changes for ServerAuthenticationConverter to be passive.

Issue: gh-5338
rwinch added a commit that referenced this issue Aug 24, 2018
@rwinch
Polish ServerAuthenticationConverter
1640a1f 
Fix package tangles

Issue: gh-5338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: docs An issue in Documentation or samples in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @edeandrea