GH-614: Fix general consumer error handling #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#614 PR spring-projects#595 added support for calling error handlers for general errors not related to listener invocation. However, the wrong `handle()` method was called. Add a default implementation of the lowest interface method in the hierarchies to `ErrorHandler` and `BatchErrorHandler` respectively and invoke that so the right method will always be invoked, regardless of the error handler type. Also see spring-projects#615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614
PR #595 added support for calling error handlers for general errors not related
to listener invocation.
However, the wrong
handle()method was called.Add a default implementation of the lowest interface method in the hierarchies to
ErrorHandlerandBatchErrorHandlerrespectively and invoke that so theright method will always be invoked, regardless of the error handler type.
Also see #615