KafkaMessageListenerContainer.handleConsumerError will never use batchErrorHandler

[tengvig]

The handleConsumerError method introduced in pull request #615 will never use batchErrorHandler. It will always use the default errorHandler:

if (this.errorHandler != null) { this.errorHandler.handle(e, Collections.emptyList(), this.consumer, KafkaMessageListenerContainer.this); } else if (this.batchErrorHandler != null) {

When the KafkaMessageListenerContainer instance is created, a LoggingErrorHandler will always be assigned as errorHandler in addition to a batchErrorHandler. Thus, the LoggingErrorHandler will always be used to handle consumer errors, e.g. quite annoying SerializationErrors.

[garyrussell]

I think you meant #616 but, yes, this is a bug.

[tengvig]

Damn, that was fast! You guys are awesome :)