@RequestMapping doesn't honor params attribute [SPR-4127]

[spring-projects-issues]

Konstantin Titorenko opened SPR-4127 and commented

After switch from RC1 to RC2 multiform controller is not working, since AnnotationMethodHandlerAdapter.HandlerMethodResolver is not checkin the params value. See the following source:

private boolean checkParameters(HttpServletRequest request, RequestMappingInfo mapping) {
if (mapping.methods.length > 0) {
for (RequestMethod type : mapping.methods) {
if (type.toString().equals(request.getMethod().toUpperCase())) {
return true;
}
}
return false;
}
.... checking params...
}

obviously "return true" statement should not be executed here. The source code in rc1 looks correct.

---

Affects: 2.5 RC2

Issue Links:

• @RequestMapping doesn't honor params attribute [SPR-4126] #8805 @RequestMapping doesn't honor params attribute ("is duplicated by")

[spring-projects-issues]

Juergen Hoeller commented

Ah, that makes sense... It's the combination with a specified request method. Thanks for pointing this out! I've fixed this for 2.5 final.

Juergen