Push database selection down to (Reactive)Neo4jClient #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
requested changes
Feb 19, 2021
There was a problem hiding this comment.
What we forgot here is that this needs to work together with a Spring Boot change: https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/neo4j/Neo4jDataAutoConfiguration.java#L87-L114 That change alone here won't make the users happy.
|
But this can only be done if the changes are merge, or? |
|
Merged with 210f209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done to give also users of the pure (Reactive)Neo4jClient the option to use the
DatabaseSelectionProvider(or its reactive pendant).We might have to discuss if the bean creation methods in the
AbstractNeo4jConfigandAbstractReactiveNeo4jConfigneed to keep the signature with the unusedDatabaseSelectionProvider/ReactiveDatabaseSelectionProviderfor a while with deprecation warnings and a replacement following in up in 6.2.0.