Move DatabaseSelection to Neo4jClient #25537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
|
Thanks for the PR.
When is this change scheduled? I can see a Spring Data |
snicoll
added
the
status: waiting-for-feedback
|
Yes, this will be part of the next milestone release ( |
snicoll
added
status: blocked
|
Thanks. I've applied this (and more) as part of switching to SD snapshots, see 46baf46 |
snicoll
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an upcoming change in the main branch of Spring Data Neo4j that requires changes in the
Neo4j(Reactive)DataAutoConfiguration.Previously the database selection was only supported on the template level and upwards. With the change (spring-projects/spring-data-neo4j#2161) the selection will be already on the
Neo4jClientlevel and as a consequence cannot be defined on a higher level (template) anymore.