Skip to content

Removes PlainSelect casting #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Removes PlainSelect casting #3870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
317a5d3
Removes PlainSelect casting
thmasker May 5, 2025
d417e88
Adds author and fixes indentation
thmasker May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../src/main/java/org/springframework/data/jpa/repository/query/JSqlParserQueryEnhancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
* @author Geoffrey Deremetz
* @author Yanming Zhou
* @author Christoph Strobl
* @author Diego Pedregal
* @since 2.7.0
*/
public class JSqlParserQueryEnhancer implements QueryEnhancer {
Expand Down Expand Up @@ -237,7 +238,7 @@ private static String detectProjection(Statement statement) {
}

StringJoiner joiner = new StringJoiner(", ");
for (SelectItem<?> selectItem : ((PlainSelect) selectBody).getSelectItems()) {
for (SelectItem<?> selectItem : selectBody.getPlainSelect().getSelectItems()) {
joiner.add(selectItem.toString());
}
return joiner.toString().trim();
Expand Down
9 changes: 9 additions & 0 deletions .../java/org/springframework/data/jpa/repository/query/JSqlParserQueryEnhancerUnitTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,4 +257,13 @@ static Stream<Arguments> mergeStatementWorksSource() {
null));
}

@Test // GH-3869
void shouldWorkWithoutFromClause() {
String query = "SELECT is_contained_in(:innerId, :outerId)";

StringQuery stringQuery = new StringQuery(query, true);

assertThat(stringQuery.getQueryString()).isEqualTo(query);
}

}