Skip to content

Conversation

thmasker
Copy link
Contributor

@thmasker thmasker commented May 5, 2025

Fixes #3869

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 5, 2025
@thmasker thmasker changed the title Fixes #3869 Removes PlainSelect casting Removes PlainSelect casting May 5, 2025
thmasker added 2 commits May 5, 2025 11:22
Signed-off-by: Diego Pedregal <[email protected]>
@thmasker thmasker marked this pull request as ready for review May 5, 2025 09:24
@thmasker
Copy link
Contributor Author

thmasker commented May 5, 2025

Feel free to comment, close or whatever you choose. Besides solving the issue I opened, I think this is also a cleaner option instead of casting...

@mp911de mp911de self-assigned this May 5, 2025
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 5, 2025
@mp911de mp911de added this to the 3.4.6 (2024.1.6) milestone May 5, 2025
mp911de pushed a commit that referenced this pull request May 5, 2025
Closes: #3869
Original pull request: #3870

Signed-off-by: Diego Pedregal <[email protected]>
mp911de added a commit that referenced this pull request May 5, 2025
Introduce doWithPlainSelect(…) callback for easier filtering of Select subtypes. Add test for known (previously) failing case.

See: #3869
Original pull request: #3870
mp911de pushed a commit that referenced this pull request May 5, 2025
Closes: #3869
Original pull request: #3870

Signed-off-by: Diego Pedregal <[email protected]>
mp911de added a commit that referenced this pull request May 5, 2025
Introduce doWithPlainSelect(…) callback for easier filtering of Select subtypes. Add test for known (previously) failing case.

See: #3869
Original pull request: #3870
mp911de pushed a commit that referenced this pull request May 5, 2025
Closes: #3869
Original pull request: #3870

Signed-off-by: Diego Pedregal <[email protected]>
mp911de added a commit that referenced this pull request May 5, 2025
Introduce doWithPlainSelect(…) callback for easier filtering of Select subtypes. Add test for known (previously) failing case.

See: #3869
Original pull request: #3870
@mp911de
Copy link
Member

mp911de commented May 5, 2025

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this May 5, 2025
mp911de pushed a commit that referenced this pull request May 16, 2025
Closes: #3869
Original pull request: #3870

Signed-off-by: Diego Pedregal <[email protected]>
mp911de added a commit that referenced this pull request May 16, 2025
Introduce doWithPlainSelect(…) callback for easier filtering of Select subtypes. Add test for known (previously) failing case.

See: #3869
Original pull request: #3870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSqlParserQueryEnhancer fails with ClassCastException during query introspection
3 participants