DATACOUCH-661 - Fix integrations tests from 650 #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
reviewed
Dec 8, 2020
| Long airportCount = airportCount = airportRepository.count().block(); | ||
| List<Airport> airports = airportRepository.findAll().collectList().block(); | ||
| for (Airport ap : airports) { | ||
| System.out.println(ap); |
There was a problem hiding this comment.
Not anymore. There were 8 airports after inserting 7. The println was to find the extra one - it was was because the deleteAll() in an earlier test did not block. I'll remove the whole findAll()/for
mikereiche
force-pushed
the
datacouch_661_fix_integration_tests_from_650
branch
from
dc30e43 to
746cdbc
Compare
mikereiche
added a commit
that referenced
this pull request
Dec 9, 2020
Co-authored-by: mikereiche <[email protected]>
mikereiche
added a commit
that referenced
this pull request
Dec 9, 2020
Co-authored-by: mikereiche <[email protected]>
This was referenced Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems were in the tests themselves. The changes in datacouch-650 are fine.
These only run with "mvn integration-test", so the failures were not being caught.