Skip to content

Commit 4b75425

Browse files
committed
Revert "DATACOUCH-661 - Fix integrations tests from 650. (#281)"
This reverts commit d300d76.
1 parent 5165f02 commit 4b75425

File tree

2 files changed

+24
-67
lines changed

2 files changed

+24
-67
lines changed

src/test/java/org/springframework/data/couchbase/domain/Airport.java

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -46,43 +46,4 @@ public String getIata() {
4646
public String getIcao() {
4747
return icao;
4848
}
49-
50-
public String toString() {
51-
StringBuilder sb = new StringBuilder();
52-
sb.append("{ id: ");
53-
sb.append(getId());
54-
sb.append(", iata: ");
55-
sb.append(iata);
56-
sb.append(", icao: ");
57-
sb.append(icao);
58-
sb.append(" }");
59-
return sb.toString();
60-
}
61-
62-
public boolean equals(Object o) {
63-
if (o == null) {
64-
return false;
65-
}
66-
if (!(o instanceof Airport)) {
67-
return false;
68-
}
69-
Airport that = (Airport) o;
70-
if (diff(this.id,that.id)) {
71-
return false;
72-
}
73-
if (diff(this.iata,that.iata)) {
74-
return false;
75-
}
76-
if (diff(this.icao,that.icao)) {
77-
return false;
78-
}
79-
return true;
80-
}
81-
82-
private boolean diff(String s1, String s2){
83-
if ((s1 == null && s2 != null) || !s1.equals(s2)) {
84-
return true;
85-
}
86-
return false;
87-
}
8849
}

src/test/java/org/springframework/data/couchbase/repository/ReactiveCouchbaseRepositoryQueryIntegrationTests.java

Lines changed: 24 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,7 @@
1616

1717
package org.springframework.data.couchbase.repository;
1818

19-
import static java.util.Arrays.asList;
20-
import static org.junit.jupiter.api.Assertions.assertEquals;
21-
import static org.junit.jupiter.api.Assertions.assertFalse;
22-
import static org.junit.jupiter.api.Assertions.assertThrows;
23-
import static org.junit.jupiter.api.Assertions.assertTrue;
24-
25-
import reactor.core.publisher.Flux;
26-
import reactor.test.StepVerifier;
27-
28-
import java.util.List;
29-
import java.util.concurrent.Callable;
30-
import java.util.concurrent.ExecutorService;
31-
import java.util.concurrent.Executors;
32-
import java.util.concurrent.Future;
33-
import java.util.stream.Collectors;
34-
19+
import com.couchbase.client.core.error.IndexExistsException;
3520
import org.junit.jupiter.api.BeforeEach;
3621
import org.junit.jupiter.api.Test;
3722
import org.springframework.beans.factory.annotation.Autowired;
@@ -50,8 +35,18 @@
5035
import org.springframework.data.couchbase.util.ClusterType;
5136
import org.springframework.data.couchbase.util.IgnoreWhen;
5237
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
38+
import reactor.test.StepVerifier;
5339

54-
import com.couchbase.client.core.error.IndexExistsException;
40+
import java.util.List;
41+
import java.util.concurrent.Callable;
42+
import java.util.concurrent.ExecutorService;
43+
import java.util.concurrent.Executors;
44+
import java.util.concurrent.Future;
45+
import java.util.stream.Collectors;
46+
47+
import static java.util.Arrays.*;
48+
import static org.assertj.core.api.Assertions.*;
49+
import static org.junit.jupiter.api.Assertions.*;
5550

5651
/**
5752
* template class for Reactive Couchbase operations
@@ -63,10 +58,13 @@
6358
@IgnoreWhen(missesCapabilities = Capabilities.QUERY, clusterTypes = ClusterType.MOCKED)
6459
public class ReactiveCouchbaseRepositoryQueryIntegrationTests extends ClusterAwareIntegrationTests {
6560

66-
@Autowired CouchbaseClientFactory clientFactory;
61+
@Autowired
62+
CouchbaseClientFactory clientFactory;
6763

68-
@Autowired ReactiveAirportRepository airportRepository; // intellij flags "Could not Autowire", but it runs ok.
69-
@Autowired ReactiveUserRepository userRepository; // intellij flags "Could not Autowire", but it runs ok.
64+
@Autowired
65+
ReactiveAirportRepository airportRepository; // intellij flags "Could not Autowire", but it runs ok.
66+
@Autowired
67+
ReactiveUserRepository userRepository; // intellij flags "Could not Autowire", but it runs ok.
7068

7169
@BeforeEach
7270
void beforeEach() {
@@ -121,7 +119,7 @@ public void testCas() {
121119

122120
@Test
123121
void count() {
124-
String[] iatas = { "JFK", "IAD", "SFO", "SJC", "SEA", "LAX", "PHX" };
122+
String[] iatas = {"JFK", "IAD", "SFO", "SJC", "SEA", "LAX", "PHX"};
125123
Future[] future = new Future[iatas.length];
126124
ExecutorService executorService = Executors.newFixedThreadPool(iatas.length);
127125
try {
@@ -131,7 +129,7 @@ void count() {
131129
airportRepository.save(airport).block();
132130
}
133131

134-
Long airportCount = airportRepository.count().block();
132+
Long airportCount = airportCount = airportRepository.count().block();
135133
assertEquals(iatas.length, airportCount);
136134

137135
airportCount = airportRepository.countByIataIn("JFK", "IAD", "SFO").block();
@@ -156,23 +154,21 @@ void count() {
156154
}
157155

158156
@Test
159-
// DATACOUCH-650
157+
// DATACOUCH-650
160158
void deleteAllById() {
161159

162160
Airport vienna = new Airport("airports::vie", "vie", "LOWW");
163161
Airport frankfurt = new Airport("airports::fra", "fra", "EDDF");
164162
Airport losAngeles = new Airport("airports::lax", "lax", "KLAX");
165163

166164
try {
167-
airportRepository.saveAll(asList(vienna, frankfurt, losAngeles)).as(StepVerifier::create)
168-
.expectNext(vienna, frankfurt, losAngeles).verifyComplete();
165+
airportRepository.saveAll(asList(vienna, frankfurt, losAngeles)).as(StepVerifier::create).verifyComplete();
169166

170-
airportRepository.deleteAllById(asList(vienna.getId(), losAngeles.getId())).as(StepVerifier::create)
171-
.verifyComplete();
167+
airportRepository.deleteAllById(asList(vienna.getId(), losAngeles.getId())).as(StepVerifier::create).verifyComplete();
172168

173169
airportRepository.findAll().as(StepVerifier::create).expectNext(frankfurt).verifyComplete();
174170
} finally {
175-
airportRepository.deleteAll().block();
171+
airportRepository.deleteAll();
176172
}
177173
}
178174

0 commit comments

Comments
 (0)