DATACOUCH-603 - Do not cast query parameters in N1qlQueryCreator. #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikereiche
force-pushed
the
datacouch_603_n1qlquerycreator_dont_cast_parameters
branch
2 times, most recently
from
2108e66 to
d3969d0
Compare
daschl
suggested changes
Oct 7, 2020
| @@ -62,6 +63,35 @@ void createsQueryCorrectly() throws Exception { | |||
| assertEquals(query.export(), " WHERE " + where("firstname").is("Oliver").export()); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Would it make sense to add another test for List?
mikereiche
force-pushed
the
datacouch_603_n1qlquerycreator_dont_cast_parameters
branch
from
d3969d0 to
5b3e888
Compare
For IN and NOT_IN - they can take varargs, an array or a JsonArray Don't cast query criteria parameters, let parameter accessor handle that. Fixed conversion of query criteria values to parameters Cleaned up QueryCriteria
mikereiche
force-pushed
the
datacouch_603_n1qlquerycreator_dont_cast_parameters
branch
from
5b3e888 to
0f7e9a0
Compare
daschl
approved these changes
Oct 9, 2020
For IN and NOT_IN - they can take varargs, and array or a JsonArray don't cast the parameter, let parameter accessor handle that. JsonArray.toString() provides the brackets, don't include them in the format Object[] array needs explicit conversion, as toString() is not sufficient Also cleaned up some weirdness in QueryCriteria.
mikereiche
force-pushed
the
datacouch_603_n1qlquerycreator_dont_cast_parameters
branch
from
4d841fa to
d57d136
Compare
mikereiche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IN and NOT_IN - they can take varargs, and array or a JsonArray
Also cleaned up some weirdness in QueryCriteria.